fix(dockerfile): reduce attack surface #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a scan was conducted that showed vulns in the resulting container as I tested this locally ``` $ docker built -t test . $ docker run --rm -it test REDACTED_DATE one of --file or --url is required ``` and it seems the container works correctly, I suggest we use this hardened tag further tests can come and i'll test them aswell
|
Thanks @georgettica :) |
georgettica
added a commit
to georgettica/token-refresher
that referenced
this pull request
Jan 9, 2022
the previous solution was ok, but the current one is more compatible with the security team - bump golang to latest (1.17) - fix secuirty vuln found with 'trivy image scan' - use ubi-micro to allow code-scanning using 'clair' - did a 'go mod vendor && go mod tidy' related to observatorium#14
georgettica
added a commit
to georgettica/token-refresher
that referenced
this pull request
Jan 24, 2022
the previous solution was ok, but the current one is more compatible with the security team - bump golang to latest (1.17) - fix secuirty vuln found with 'trivy image scan' - use ubi-micro to allow code-scanning using 'clair' - did a 'go mod vendor && go mod tidy' - gofmt a file using 'gofmt -w <filename>' related to observatorium#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a scan was conducted that showed vulns in the resulting container
as I tested this locally
and it seems the container works correctly, I suggest we use this
hardened tag
further tests can come and i'll test them aswell